Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authorization #80

Merged
merged 8 commits into from
Dec 17, 2024
Merged

Add authorization #80

merged 8 commits into from
Dec 17, 2024

Conversation

sbckr
Copy link
Member

@sbckr sbckr commented Nov 21, 2024

No description provided.

@sbckr sbckr force-pushed the add-authorization branch from 6767663 to b2b3d1c Compare November 21, 2024 10:01
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.73%. Comparing base (39055d0) to head (7d92b12).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #80      +/-   ##
============================================
- Coverage     82.42%   81.73%   -0.69%     
============================================
  Files            34       30       -4     
  Lines          3277     3323      +46     
  Branches         10        0      -10     
============================================
+ Hits           2701     2716      +15     
- Misses          491      519      +28     
- Partials         85       88       +3     
Flag Coverage Δ
java-client ?
service 81.73% <ø> (-0.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39055d0...7d92b12. Read the comment docs.

@sbckr sbckr force-pushed the add-authorization branch from 00a529d to 75ee4d1 Compare November 21, 2024 16:47
@sbckr sbckr marked this pull request as ready for review December 16, 2024 15:10
@sbckr sbckr requested a review from a team as a code owner December 16, 2024 15:10
Copy link
Member

@strieflin strieflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a single typo only. Everything else LGTM.

@sbckr sbckr requested a review from strieflin December 17, 2024 06:23
Copy link
Member

@strieflin strieflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbckr sbckr force-pushed the add-authorization branch 3 times, most recently from 1b480f3 to 70a3f67 Compare December 17, 2024 08:30
Signed-off-by: Sebastian Becker <sebastian.becker@de.bosch.com>
Signed-off-by: Sebastian Becker <sebastian.becker@de.bosch.com>
Signed-off-by: Sebastian Becker <sebastian.becker@de.bosch.com>
Signed-off-by: Sebastian Becker <sebastian.becker@de.bosch.com>
Signed-off-by: Sebastian Becker <sebastian.becker@de.bosch.com>
Signed-off-by: Sebastian Becker <sebastian.becker@de.bosch.com>
Signed-off-by: Sebastian Becker <sebastian.becker@de.bosch.com>
Signed-off-by: Sebastian Becker <sebastian.becker@de.bosch.com>
@sbckr sbckr force-pushed the add-authorization branch from 70a3f67 to 7d92b12 Compare December 17, 2024 08:33
@sbckr sbckr merged commit d2b2899 into master Dec 17, 2024
11 checks passed
@sbckr sbckr deleted the add-authorization branch December 17, 2024 08:39
This was referenced Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants