Follow-up PR to allow for meta setting from Chrome Extension #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximized
changed the title
This was
linked to
issues
Jan 7, 2024
rgossiaux
reviewed
Jan 9, 2024
chrome_extension/cardboard/popup.js
Outdated
| // TODO: Make this configurable | ||
| const HUNT_NUMBER = 10; | ||
|
|
||
| let URL = DEV_URL; |
There was a problem hiding this comment.
URL already exists as a global, we shouldn't shadow it https://developer.mozilla.org/en-US/docs/Web/API/URL/URL
There was a problem hiding this comment.
Changed to TARGET_URL
Change URL to TARGET_URL
Add TODO about deploymet
npinsker
pushed a commit
that referenced
this pull request
Jan 10, 2024
* Assign a single meta at puzzle creation time * pre-commit * Remove comment * Modify host_permissions to match suggests from https://developer.chrome.com/docs/extensions/develop/concepts/match-patterns * Chrome Extension changes to support assigning the meta in the extension * update version number * Chrome extension changes to match meta assignment functionality * Undo debugging * update * update * Update popup.js Change URL to TARGET_URL * Update popup.js Add TODO about deploymet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.