admin button to auto-gen & link Discord roles #746
Conversation
|
Why did you move this from the hunt edit page to the sidebar? I thought that made the most sense to me. I also think it's unlikely we ever want to modify these during the hunt FWIW |
|
idk i felt like i was expecting we'd want to add new tags to Discord as well, but it doesn't matter much |
npinsker
force-pushed
the
discord-autoupdate
branch
from
890de0b to
62173ea
Compare
|
moved back to |
chat/tasks.py
Outdated
| if tag.color != PuzzleTagColor.BLUE and tag.color != PuzzleTagColor.WHITE: | ||
| continue |
There was a problem hiding this comment.
I think we should also check if it's a default tag
chat/tasks.py
Outdated
| if existing_chat_role.exists(): | ||
| obj = existing_chat_role.first() | ||
| if obj.role_id != discord_roles_by_name[tag.name]["id"]: | ||
| with transaction.atomic(): |
There was a problem hiding this comment.
Does this actually do anything if we're just doing a single operation? ditto below
hunts/views.py
Outdated
| chat.tasks.sync_roles( | ||
| hunt, | ||
| settings.CHAT_DEFAULT_SERVICE, | ||
| ) |
There was a problem hiding this comment.
I think this will run this synchronously by the web process, right? Need to call .delay() if you want to create a task
addresses #671
ChatRolefor all Discord roles, meaning people with those roles will get pinged when a puzzle's tagged with the corresponding tag