upgrade to bootstrap 5 #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npinsker
force-pushed
the
npinsker/bootstrap-5
branch
from
11b40bc to
ab7428e
Compare
rgossiaux
approved these changes
Jan 15, 2025
npinsker
force-pushed
the
npinsker/bootstrap-5
branch
from
467e77e to
6760f74
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display issues surfaced from recently upgrading
react-bootstrapwithout a corresponding upgrade to our bootstrap version (viatoggle-bootstrap, which uses bootstrap v4).toggle-bootstrapusing bootstrap v5 doesn't exist, bc bootstrap v5 natively supports dark mode, so i replaced the library with vanilla.The white tag coloring issue isn't bootstrap-related but I fixed that as well.
this caused a few more CSS issues (e.g. v5 uses css custom properties and v4 uses hard-coded constants), which i did my best to fix, but something may have slipped through -- sorry!