Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off autocomplete in form modals #852

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

akirabaruah
Copy link
Contributor

@akirabaruah akirabaruah commented Jan 15, 2025

Prevents password managers from mistakenly autofilling names, etc.

@akirabaruah akirabaruah requested a review from rgossiaux January 15, 2025 20:18
@akirabaruah
Copy link
Contributor Author

akirabaruah commented Jan 15, 2025

@rgossiaux I tested with my browser autocomplete and this change works as expected. I don't use 1Password, but based on their docs, this should work for the 1Password extension too.

Copy link
Contributor

@rgossiaux rgossiaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks!

@akirabaruah akirabaruah merged commit 2b1db7c into cardinalitypuzzles:main Jan 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants