Issue with Office 365 Payload Construction in NotifyOffice365

[Kathir18K]

Description

When sending emails through the Office 365 notifier, the subject and body are not being included in the final payload, resulting in empty emails. This appears to be due to how the payload dictionary is being updated in the send() method of the NotifyOffice365 class.

---

Current Behavior

• Emails are sent successfully (202 response).
• The payload only includes from, toRecipients, and saveToSentItems.
• Subject and body are missing from the final payload.
• The issue occurs with both notify() and send() methods.

---

Expected Behavior

• The subject and body should be included in the final payload sent to the Microsoft Graph API.
• Emails should contain the specified subject and body content.

---

Debug Log Evidence

# Current Payload (from debug logs):
{
    "message": {
        "from": {
            "emailAddress": {
                "address": "user@domain.com",
                "name": "Apprise"
            }
        },
        "toRecipients": [{
            "emailAddress": {
                "address": "user@domain.com"
            }
        }]
    },
    "saveToSentItems": "true"
}

# Expected Payload:
{
    "message": {
        "subject": "Test Email",
        "body": {
            "contentType": "Text",
            "content": "This is a test email body"
        },
        "from": {
            "emailAddress": {
                "address": "user@domain.com",
                "name": "Apprise"
            }
        },
        "toRecipients": [{
            "emailAddress": {
                "address": "user@domain.com"
            }
        }]
    },
    "saveToSentItems": "true"
}

Root Cause

The issue occurs in the NotifyOffice365.send() method of the Office 365 plugin. The payload dictionary is being overwritten instead of merged when adding the 'from' information, causing loss of subject and body data.

Current Implementation:

def send(self, body, title='', notify_type=NotifyType.INFO, attach=None, **kwargs):
   """
   Perform Office 365 Notification
   """
   # ... rest of the implementation remains the same
   payload = {
       'message': {
           'subject': title,
           'body': {
               'contentType': content_type,
               'content': body,
           },
       },
       'saveToSentItems': 'true'
   }

   # This update overwrites the entire 'message' dictionary
   payload.update({
       'message': {
           'from': {
               "emailAddress": {
                   "address": self.from_email,
                   "name": self.from_name or self.app_id,
               }
           },
       }
   })
    # ... rest of the implementation remains the same

Suggested Fix

The issue can be resolved by properly merging the dictionaries instead of overwriting them. Here's the proposed fix for the send() method in NotifyOffice365:

def send(self, body, title='', notify_type=NotifyType.INFO, attach=None, **kwargs):
   """
   Perform Office 365 Notification
   """
    # ... rest of the implementation remains the same
   payload = {
       'message': {
           'subject': title,
           'body': {
               'contentType': content_type,
               'content': body,
           },
       },
       'saveToSentItems': 'true'
   }

    # ... rest of the implementation remains the same
   payload['message'].update({
       'from': {
           "emailAddress": {
               "address": self.from_email,
               "name": self.from_name or self.app_id,
           }
       }
   })
    # ... rest of the implementation remains the same
   payload['message'].update({
       'toRecipients': [{
           'emailAddress': {
               'address': self.source
           }
       }]
   })

    # ... rest of the implementation remains the same

[caronc]

Well that's embarassing 👀 . Great find and thank you so much for pin-pointing the solution.

I additionally added some unit tests to prevent this from ever happening again.