Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Office 365 posts include subject and body now #1274

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Conversation

caronc
Copy link
Owner

@caronc caronc commented Jan 19, 2025

Description:

Related issue (if applicable): #1271

Fixed bug causing body and subject to be cleared

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@1271-office-365-payload?

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
 "o365://credentials"

@caronc caronc linked an issue Jan 19, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.36%. Comparing base (a2a2216) to head (bf82424).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1274   +/-   ##
=======================================
  Coverage   99.36%   99.36%           
=======================================
  Files         159      159           
  Lines       20718    20718           
  Branches     3724     3724           
=======================================
  Hits        20587    20587           
  Misses        121      121           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit fcc4939 into master Jan 19, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Office 365 Payload Construction in NotifyOffice365
1 participant