-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools exec wrappers #107
Tools exec wrappers #107
Conversation
|
Coverage Report for ./apps/cli
File Coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve test coverage, we should be able to force the docker execution even if we have the binary on the host system.
export type ExecaOptionsDockerFallback = Options & { image?: string, dockerOnly?: bool };
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving so we move one, but we stiil need to use the exec wrapper elsewhere in the code, right?
Right. |
74a7572
to
e171082
Compare
not needed anymore
e171082
to
f8ca692
Compare
This creates wrappers for the external tools we use in the CLI.
Each publishes a
version
method to report aSemVer
, which we can use to check the minimum version in the execution itself, or in adoctor command
.I've setup the integration tests to use the
cartesi/sdk:0.11.0
docker image as fallback, as I'm not sure what is installed in the CI environment.