Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): compose image definition in a single place #151

Open
wants to merge 4 commits into
base: feature/cli-run-v2
Choose a base branch
from

Conversation

endersonmaia
Copy link
Contributor

This pull request introduces a refactor to the Docker Compose configurations in the CLI application to use a base configuration file. The main changes include the addition of a base Docker Compose file and the modification of existing service definitions to extend from this base file.

Refactor Docker Compose configurations:

  • apps/cli/src/commands/run.ts: Modified to include the base Docker Compose file in the list of compose files.

  • apps/cli/src/node/docker-compose-anvil.yaml: Updated to extend from the base Docker Compose file for the anvil and dapp_deployer services. [1] [2]

  • apps/cli/src/node/docker-compose-base.yaml: Added a new base Docker Compose file defining common services sdk_image and rollups_node_image.

  • apps/cli/src/node/docker-compose-bundler.yaml, apps/cli/src/node/docker-compose-database.yaml, apps/cli/src/node/docker-compose-paymaster.yaml, apps/cli/src/node/docker-compose-validator.yaml: Updated to extend from the base Docker Compose file for their respective services. [1] [2] [3] [4]

@endersonmaia endersonmaia requested a review from tuler February 4, 2025 13:21
Copy link

changeset-bot bot commented Feb 4, 2025

🦋 Changeset detected

Latest commit: 2fc76ba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cartesi/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Coverage Report for ./apps/cli

Status Category Percentage Covered / Total
🔵 Lines 30.97% 293 / 946
🔵 Statements 31.1% 298 / 958
🔵 Functions 36.95% 51 / 138
🔵 Branches 27.88% 121 / 434
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/cli/src/commands/run.ts 0% 0% 0% 0% 9-233
Generated in workflow #256 for commit 2fc76ba by the Vitest Coverage Report Action

@endersonmaia endersonmaia force-pushed the feature/single-place-image-definition branch from a27b565 to f350102 Compare February 4, 2025 13:25
@endersonmaia endersonmaia self-assigned this Feb 4, 2025
@endersonmaia endersonmaia force-pushed the feature/single-place-image-definition branch from f350102 to 2fc76ba Compare February 4, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant