Remove unused clock parameter from FakeJob that causes a breaking ABI change
#3279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrw
approved these changes
May 30, 2024
mpeyper
force-pushed
the
mpeyper/remove-unused-parameter
branch
from
84a3e6e to
548101b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #3252 introduced a new argument to
FakeJobthat is a breaking API/ABI change, but the argument was not actually being used.This change removes it again as it's blocking some dependency updates due to incompatible ABI errors. Note that this could be an breaking ABI change for any consumer that have updated to the new API already.