Connection limiter #415
Open
Connection limiter #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zajko
reviewed
Feb 25, 2025
zajko
reviewed
Feb 25, 2025
zajko
reviewed
Feb 25, 2025
zajko
reviewed
Feb 25, 2025
rpc_sidecar/src/rpcs.rs
Outdated
| let limiter = Arc::new(DefaultKeyedRateLimiter::keyed(Quota::per_second(qps_limit))); | ||
|
|
||
| // Try to get client's IP address from headers, with fallback to connection IP address. | ||
| let host_ip = warp::header(X_REAL_IP) |
There was a problem hiding this comment.
Yes, for reverse proxies.
There was a problem hiding this comment.
Where do we use reverse proxies?
zajko
reviewed
Feb 25, 2025
rpc_sidecar/src/rpcs.rs
Outdated
| .and_then(move |ip_addr: IpAddr| { | ||
| let limiter = limiter.clone(); | ||
| async move { | ||
| if let Err(negative) = limiter.check_key(&ip_addr) { |
There was a problem hiding this comment.
I thought we don't do ip-based limiting?
There was a problem hiding this comment.
I'd say it's a nice-to-have feature.
zajko
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.