Merge pull request #3020 from v-hclaveria/test_history_firefox

Styling adjustment on Test History for Firefox
catchpoint · Dec 22, 2023 · e7e48fb · e7e48fb
2 parents 95ea967 + 992b2da
commit e7e48fb
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 13 deletions.
diff --git a/www/assets/css/pagestyle2.css b/www/assets/css/pagestyle2.css
@@ -4517,6 +4517,10 @@ table.checklist td {
   padding: 1rem;
 }
 
+.history th.idSelect {
+    vertical-align: baseline;
+}
+
 .history th.date,
 .history td.date {
   white-space: nowrap;
@@ -6660,6 +6664,20 @@ div.overflow-container > *,
   position: relative;
 }
 
+.scrollableHistoryTable {
+    overflow: auto;
+}
+
+.scrollable-td {
+    padding: unset;
+}
+
+.scrollable-td-content {
+    overflow-x: auto;
+    padding: 1em;
+    padding-top: 0em;
+}
+
 span.units {
   font-size: 0.5em;
   font-weight: 300;

diff --git a/www/resources/views/pages/testhistory.blade.php b/www/resources/views/pages/testhistory.blade.php
@@ -35,11 +35,11 @@
         <div class="history-controls">
             <input id="CompareBtn" type="submit" value="Compare Selected Tests">
         </div>
-        <div class="scrollableTable">
+        <div class="scrollableHistoryTable">
             <table id="history" class="history pretty" border="0" cellpadding="5px" cellspacing="0">
                 <thead>
                     <tr>
-                        <th class="pin"><span>Select to compare</span></th>
+                        <th><span>Select to compare</span></th>
                         <th class="url">URL</th>
                         <th class="date">Run Date</th>
                         <th class="location">Run From</th>
@@ -50,19 +50,19 @@
                     <tbody id="historyBody">
                         @foreach ($test_history as $record)
                             <tr>
-                                <th><input type="checkbox" name="t[]" value="{{ $record->getTestId() }}" aria-label="Select this test" /></th>
-                                <td class="url"><a href="/result/{{ $record->getTestId() }}/">{{ $record->getUrl() }}</a></td>
+                                <th class="idSelect"><input type="checkbox" name="t[]" value="{{ $record->getTestId() }}" aria-label="Select this test" /></th>
+                                <td class="url scrollable-td"><div class="scrollable-td-content"><a href="/result/{{ $record->getTestId() }}/">{{ $record->getUrl() }}</a></div></td>
                                 <td class="date">{{ date_format(date_create($record->getStartTime()), 'M d, Y g:i:s A e') }}</td>
-                                <td class="location">{{ $record->getLocation() }}</td>
+                                <td class="location scrollable-td"><div class="scrollable-td-content">{{ $record->getLocation() }}</div></td>
                                 <td class="label">{{ $record->getLabel() }}</td>
                             </tr>
                         @endforeach
                     </tbody>
                 @endif
             </table>
         </div>
-
-
+        
+        
         @if ($local)
             <input type="hidden" name="local" value="1">
         @endif

diff --git a/www/resources/views/pages/testhistoryadmin.blade.php b/www/resources/views/pages/testhistoryadmin.blade.php
@@ -72,7 +72,7 @@
                         'labelTxt' => $labelTxt,
                     ])
                 <tr>
-                    <th>
+                    <th class="idSelect">
                         @if (isset($guid) && $video && !($url == "Bulk Test" || $url == "Multiple Locations test"))
                             <input type="checkbox" name="t[]" value="{{ $guid }}" title="First View">
                             @if ($repeat)
@@ -89,10 +89,12 @@
                             </b>
                         @endif
                     </td>
-                    <td class="location">{!! $location !!}
-                        @if ($video)
-                            <span>(video)</span>
-                        @endif
+                    <td class="location scrollable-td">
+                        <div class="scrollable-td-content">{!! $location !!}
+                            @if ($video)
+                                <span>(video)</span>
+                            @endif
+                        </div>
                     </td>
                     @if ($includeip)
                         <td class="ip">{{ $ip }}</td>
@@ -113,7 +115,7 @@
                     <td title="{{ $label }}" class="label">
                         <a href="{{ $link }}" id="label_{{ $guid }}">{{ $labelTxt }}</a>
                     </td>
-                    <td class="url"><a title="{{ $url }}" href="{{ $link }}">{{ $shortURL }}</a></td>
+                    <td class="url scrollable-td"><div class="scrollable-td-content"><a title="{{ $url }}" href="{{ $link }}">{{ $shortURL }}</a></div></td>
                 </tr>
                 @endforeach
             </table>