Issue #309: !prepembed webhook support #329
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbrxyz
reviewed
Jan 14, 2021
Comment on lines
+1557
to
+1568
| embed = assembleEmbed( | ||
| title=title, | ||
| desc=desc, | ||
| titleUrl=titleUrl, | ||
| hexcolor=hexcolor, | ||
| webcolor=webcolor, | ||
| thumbnailUrl=thumbnailUrl, | ||
| fields=fields, | ||
| footerText=footerText, | ||
| footerUrl=footerUrl, | ||
| imageUrl=imageUrl | ||
| ) |
There was a problem hiding this comment.
Why are the authorName, authorUrl, and authorIcon parameters removed from this function call? Those parameters should still be able to be set because they belong to the embed itself.
There was a problem hiding this comment.
Seems kinda redundant to display the username and pfp on the embed and then again on the webhook. The only other use case is if we want the webhook to display something different to the author of the embed. This probably can be implemented easily ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #309.