Skip to content

Commit

Permalink
benchmark: use timings for library call, not the whole wrapper
Browse files Browse the repository at this point in the history
  • Loading branch information
cdump committed Feb 23, 2025
1 parent 57f1fb4 commit d114a03
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
4 changes: 1 addition & 3 deletions benchmark/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -64,15 +64,13 @@ $(UNPACK_TARGETS):
.SECONDEXPANSION:
$(RUN_TARGETS): datasets/$$(notdir $$@)
$(info [*] Running $@...)
/bin/time -f '%e' \
$(DOCKER) run --network=none --cpus=$(DOCKER_CPUS) --rm \
-v $(DATASET)/$(notdir $@):/dataset \
-v $(RES):/mnt \
-it $(DOCKER_PREFIX)-$(basename $(subst /,,$(dir $@))) \
$(subst .,,$(suffix $(subst /,,$(dir $@)))) \
/dataset \
/mnt/$(subst /,_,$@).json \
/mnt/$(PROVIDER_BASE).selectors_$(notdir $@).json \
2> $(RES)/$(subst /,_,$@).time
/mnt/$(PROVIDER_BASE).selectors_$(notdir $@).json

.PHONY: benchmark-selectors benchmark-arguments benchmark-mutability build run-selectors run-arguments run-mutability $(BUILD_TARGETS) $(RUN_TARGETS)
7 changes: 3 additions & 4 deletions benchmark/compare.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ def load_data(btype: str, dname: str, providers: list[str], results_dir: str) ->
for pname in providers:
with open(f'{results_dir}/{pname}.{btype}_{dname}.json', 'r') as fh:
data.append(json.load(fh))
with open(f'{results_dir}/{pname}.{btype}_{dname}.time', 'r') as fh:
times.append(float(fh.read()))
total_time = sum(ts if ts > 0 else 1 for (ts, _) in data[-1].values())
times.append(total_time / 1000.)
return data, times

def process_selectors(dname: str, providers: list[str], results_dir: str):
Expand Down Expand Up @@ -397,7 +397,7 @@ def show_arguments_or_mutability(providers: list[str], all_results: list, show_e
},
'flow': {
'datasets': ['largest1k', 'random50k', 'vyper'],
'providers': ['evmole-rs', 'evm-cfg', 'ethersolve', 'sevm', 'evm-cfg-builder', 'heimdall-rs']
'providers': ['evmole-rs', 'evm-cfg', 'ethersolve', 'evmlisa', 'sevm', 'evm-cfg-builder', 'heimdall-rs']
}
}

Expand Down Expand Up @@ -444,6 +444,5 @@ def show_arguments_or_mutability(providers: list[str], all_results: list, show_e
show_arguments_or_mutability(cfg.providers, results, cfg.show_errors)

elif cfg.mode == 'flow':
# assert len(cfg.datasets) == 1
results = [process_flow(cfg.datasets[0], cfg.providers, cfg.results_dir)]
show_flow(cfg.providers, results, cfg.show_errors)

0 comments on commit d114a03

Please sign in to comment.