Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lazy-adr: erasure coded block propagation #163

Merged
merged 7 commits into from
Mar 9, 2021
Merged

Conversation

tac0turtle
Copy link
Collaborator

Description

This adr outlines changes required to have erasure coded block propagation/pulling

Closes: #XXX

@liamsi
Copy link
Member

liamsi commented Feb 16, 2021

ref: #85

@github-actions github-actions bot added the Stale label Feb 27, 2021
@liamsi liamsi removed the Stale label Mar 2, 2021
@celestiaorg celestiaorg deleted a comment from github-actions bot Mar 2, 2021
LoadBlockCommit(height int64) *types.Commit
LoadSeenCommit(height int64) *types.Commit
}
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. The Store interface for light clients is not an option because it expects a canonical commit with each header?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, in tendermint, light clients request data from full nodes. In our case they only need to connect to a full node to get DAheaders and header. Otherwise, all requests will go through IPFS, correct?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is correct. Implementation wise, we should prob. do this in (at least) two steps: add requesting block data from IPFS while having the store and the reactors work as before, then step by step replace everything by ipfs apis.

@tac0turtle tac0turtle marked this pull request as ready for review March 8, 2021 22:26
@tac0turtle tac0turtle requested a review from musalbas as a code owner March 8, 2021 22:26
@tac0turtle tac0turtle requested a review from liamsi March 8, 2021 22:26
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @marbar3778! 👍🏼

Do you mind opening a few issues that can be implemented as an outcome of this ADR?

I think, we should merge this, start implementing different portions, and keep the ADR in sync with the implementation.

@tac0turtle tac0turtle merged commit 91c232e into master Mar 9, 2021
@tac0turtle tac0turtle deleted the marko-lazy-adr001 branch March 9, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants