-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lazy-adr: erasure coded block propagation #163
Conversation
ref: #85 |
LoadBlockCommit(height int64) *types.Commit | ||
LoadSeenCommit(height int64) *types.Commit | ||
} | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me. The Store
interface for light clients is not an option because it expects a canonical commit with each header?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, in tendermint, light clients request data from full nodes. In our case they only need to connect to a full node to get DAheaders and header. Otherwise, all requests will go through IPFS, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is correct. Implementation wise, we should prob. do this in (at least) two steps: add requesting block data from IPFS while having the store and the reactors work as before, then step by step replace everything by ipfs apis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @marbar3778! 👍🏼
Do you mind opening a few issues that can be implemented as an outcome of this ADR?
I think, we should merge this, start implementing different portions, and keep the ADR in sync with the implementation.
Description
This adr outlines changes required to have erasure coded block propagation/pulling
Closes: #XXX