cherrypick e2e changes regarding maverick from tm master #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be useful to understand the overall purpose and structure of the end-to-end tests. (cherry picked from commit 1570d26)
E2E tests often fail due to fast sync stalls causing the validator to miss signing blocks. This increases the tolerance for missed signatures to 2/3 to allow validators to spend more time starting up. (cherry picked from commit 66ba12d)
E2E tests often fail because validators miss signing or proposing blocks. Often this is because e.g. there's a lot of disruption in the network or it takes a long time to start up all the nodes. This changes the test criteria to only check for 3 signed/proposed blocks, rather than a fraction of the expected blocks. This should be enough to catch most issues, apart from performance problems causing nodes to miss signing/proposing, but we may want separate tests for those sorts of things. (cherry picked from commit 3d01d98)
(cherry picked from commit 5f88d6a)
(cherry picked from commit d4b0477)
liamsi
changed the title
Are we going to bring it back ??? |
Wondertan
approved these changes
Apr 21, 2021
| @@ -121,7 +121,7 @@ jobs: | |||
| - run: | | |||
| cat ./*profile.out | grep -v "mode: atomic" >> coverage.txt | |||
| if: env.GIT_DIFF | |||
| - uses: codecov/codecov-action@v1.4.0 | |||
| - uses: codecov/codecov-action@v1.4.1 | |||
There was a problem hiding this comment.
Is this related to the change?
| } else { | ||
| err = startMaverick(cfg) | ||
| } | ||
| // FIXME: Temporarily remove maverick until it is redesigned |
There was a problem hiding this comment.
Ok, I see
Maverick: I'll be back
There was a problem hiding this comment.
Does the tm team plan to redesign maverick or we? IMO: good redesign would require consensus redesign in a more modular way. Copying code is nah
There was a problem hiding this comment.
Yeah, it redesigned it already as far as I undertand. It's now part of the other e2e tests (at least the most relevant parts).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR only takes on the easy part of #292 (removing maverick) but I actually think we do not need to get tendermint/tendermint#6276 and related changes to close #292 and unblock work on the consensus reactor (#293).
Each commit here was cherry-picked from tendermint master (you can look at corresponding squash merged PRs in tendermint). I've included some that seemed to further help with e2e flakiness. So hopefully this also improves e2e test reliability for this repo.
The last commit (6628237) bumps the codecov action version (see https://twitter.com/thomasrockhu/status/1384619989634797576).
Closes: #292