Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH #2939: Remove small screen design for card and list-item #2949

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

GH #2939: Remove small screen design for card and list-item #2949

wants to merge 5 commits into from

Conversation

chrieinv
Copy link
Contributor

@chrieinv chrieinv commented Feb 5, 2025 •
edited
Loading

  • Remove small screen design for card and list-item
  • Show language name in list and on hover on language code on cards
  • Collect dark theme in own file, rename file containing Edlib theme
  • Fix secondary outline button too low contrast in dark theme (The Filter and Clear filter buttons)

@chrieinv
GH #2939: Remove small screen design for card and list-item. Show lan…
88601f8 
…guage name, other minor design adjustments
@chrieinv chrieinv linked an issue Feb 5, 2025 that may be closed by this pull request
Remove small screen version of content card #2939
Open
@github-actions github-actions bot added the Component: Hub The core of Edlib - handling search, filtering, my content and shared content label Feb 5, 2025
@github-actions github-actions bot added the language All issues related to language and translation label Feb 6, 2025
@chrieinv chrieinv marked this pull request as draft February 6, 2025 13:50
@chrieinv chrieinv marked this pull request as ready for review February 7, 2025 07:37
@chrieinv chrieinv requested review from emmachughes and removed request for emmachughes February 7, 2025 07:37
@tmkarlsen tmkarlsen requested a review from emmachughes February 7, 2025 11:48
emmachughes
emmachughes requested changes Feb 11, 2025
View reviewed changes
Copy link
Member

@emmachughes emmachughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many assorted changes with no relation to each other. At the very least this should be split into different commits for each thing this fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmachughes emmachughes emmachughes requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Component: Hub The core of Edlib - handling search, filtering, my content and shared content language All issues related to language and translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove small screen version of content card
2 participants
@chrieinv @emmachughes