[release-next] Rebase and update signature verification section #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maël Valais <mael@vls.dev>
Signed-off-by: Krzysztof Pudłowski <djkormo@gmail.com>
Signed-off-by: Krzysztof Pudłowski <djkormo@gmail.com>
adding new version of adcs-issuer
Signed-off-by: Maël Valais <mael@vls.dev>
…-not-recommended Venafi Issuer: Explain why "Do not select 'refresh token enabled'"
changing release site for adcs-issuer Signed-off-by: Krzysztof Pudłowski <djkormo@gmail.com>
changing release site for adcs-issuer
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
…-reviewer add thatsmrtalbot as reviewer
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Format the issuers table
Signed-off-by: Prashant Antil <Prashant.Antil@GlobalSign.com>
Add GlobalSign Atlas Issuer
Fix error in request-certificate diagram
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
Tested with: * cert-manager: v1.13.3 * AKS Kubernetes: 1.27.7 * az: 2.56.0 Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
Add FAQ entry on ca.crt
Verify the AKS + LetsEncrypt tutorial
Update link to code in faqs
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
…-update Improve + fix signature verification examples
Signed-off-by: Richard Wall <wallrj@users.noreply.github.com>
Signed-off-by: Richard Wall <wallrj@users.noreply.github.com>
…bleshooting Webhook troubleshooting: advise people to set `timeoutSeconds` to 30 seconds
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
…LI references and API docs Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Co-authored-by: Tim Ramlot <42113979+inteon@users.noreply.github.com> Signed-off-by: Richard Wall <wallrj@users.noreply.github.com>
…e was enabled by default Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
Signed-off-by: SpectralHiss <houssem.elfekih@jetstack.io>
* Explains the motivation behind the OtherName feature Signed-off-by: SpectralHiss <houssem.elfekih@jetstack.io>
Signed-off-by: SpectralHiss <houssem.elfekih@jetstack.io>
Co-authored-by: Richard Wall <wallrj@users.noreply.github.com> Signed-off-by: Houssem El Fekih <hassoum92@hotmail.com>
Co-authored-by: Richard Wall <wallrj@users.noreply.github.com> Signed-off-by: Houssem El Fekih <hassoum92@hotmail.com>
Co-authored-by: Richard Wall <wallrj@users.noreply.github.com> Signed-off-by: Houssem El Fekih <hassoum92@hotmail.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Peter Fiddes <peter.fiddes@gmail.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
jetstack-bot
added
the
dco-signoff: no
|
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
jetstack-bot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jetstack-bot
added
the
size/XXL
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Closing in favour of #1393 1393 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't remember how we update release-next in the face of a conflict, but this (if force-pushed) would fix release-next.
Raising this so the changes are available - will work out how to merge tomorrow.