Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate approver-policy API docs #1415

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Regenerate approver-policy API docs #1415

merged 1 commit into from
Feb 7, 2024

Conversation

erikgb
Copy link
Contributor

@erikgb erikgb commented Feb 4, 2024

Also fixing a few bugs in the generate script caused by project restructuring.

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 4, 2024
@inteon
Copy link
Member

inteon commented Feb 4, 2024

/approve
/lgtm
Thanks for fixing the script and keeping the generated docs up-to-date.

@jetstack-bot jetstack-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 4, 2024
@erikgb
Copy link
Contributor Author

erikgb commented Feb 4, 2024

@inteon Any idea how to fix the failing build? The error message isn't clear to me.

@inteon
Copy link
Member

inteon commented Feb 5, 2024 •
edited
Loading

@erikgb I see the following error: Expected a closing tag for <td> (153:9-153:13)
This might be caused by an unescaped tag or something.
Will investigate this further.

@inteon
Copy link
Member

inteon commented Feb 5, 2024

@erikgb this line seems to be broken:

website/content/docs/policy/approval/approver-policy/api-reference.md

Line 168 in 5e67a12

```<br/>

This might be a bug in the docs generator, but feel free to just fix the generated code if you do not want to root cause this.

@erikgb erikgb force-pushed the regen-approver-policy-docs branch from 5e67a12 to bf4ba17 Compare February 5, 2024 19:35
@jetstack-bot jetstack-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2024
@erikgb
Copy link
Contributor Author

erikgb commented Feb 6, 2024

This might be a bug in the docs generator, but feel free to just fix the generated code if you do not want to root cause this.

Modifying something generated feels wrong. I'll try to get to the bottom of this. Any pointers would be appreciated.

@erikgb erikgb force-pushed the regen-approver-policy-docs branch 2 times, most recently from a90b07c to c69b4aa Compare February 6, 2024 16:26
@erikgb erikgb mentioned this pull request Feb 6, 2024
Merged
@erikgb erikgb force-pushed the regen-approver-policy-docs branch from c69b4aa to bfff8ac Compare February 7, 2024 09:11
@erikgb erikgb mentioned this pull request Feb 7, 2024
Merged
@erikgb
Regenerate approver-policy API docs
06fd0aa 
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
@erikgb erikgb force-pushed the regen-approver-policy-docs branch from bfff8ac to 06fd0aa Compare February 7, 2024 10:03
@netlify Netlify
Copy link

netlify bot commented Feb 7, 2024

✅ Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 06fd0aa
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/65c35582c02e7000087b4f12
😎 Deploy Preview https://deploy-preview-1415--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@erikgb
Copy link
Contributor Author

erikgb commented Feb 7, 2024

Finally! It works now. 🎉 PTAL!

SgtCoDFish
SgtCoDFish approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Looks good! Thanks for this 😁

https://deploy-preview-1415--cert-manager-website.netlify.app/docs/policy/approval/approver-policy/api-reference/

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2024
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit dbdf6e1 into cert-manager:master Feb 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erikgb @inteon @jetstack-bot @SgtCoDFish