Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AdditionalCertificateOutputFormats alpha warning #1468

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Remove AdditionalCertificateOutputFormats alpha warning #1468

merged 1 commit into from
Apr 29, 2024

Conversation

erikgb
Copy link
Contributor

@erikgb erikgb commented Apr 29, 2024

@cert-manager-prow cert-manager-prow bot requested a review from inteon April 29, 2024 08:00
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 29, 2024
@erikgb erikgb mentioned this pull request Apr 29, 2024
Merged
@netlify Netlify
Copy link

netlify bot commented Apr 29, 2024 •
edited
Loading

✅ Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 9b04314
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/662f557fe3a4510008c7a2fd
😎 Deploy Preview https://deploy-preview-1468--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@inteon
Copy link
Member

inteon commented Apr 29, 2024

Thanks @erikgb, the change is great, but it should be merged into the release-next branch.
/hold

@cert-manager-prow cert-manager-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2024
@erikgb erikgb force-pushed the additional-output-formats-beta branch from 079a652 to f7f458d Compare April 29, 2024 08:06
@cert-manager-prow cert-manager-prow bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 29, 2024
@erikgb erikgb changed the base branch from master to release-next April 29, 2024 08:06
@erikgb erikgb force-pushed the additional-output-formats-beta branch from f7f458d to e492ae7 Compare April 29, 2024 08:07
@erikgb
Remove AdditionalCertificateOutputFormats alpha warning
9b04314 
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
@erikgb erikgb force-pushed the additional-output-formats-beta branch from e492ae7 to 9b04314 Compare April 29, 2024 08:08
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 29, 2024
@erikgb
Copy link
Contributor Author

erikgb commented Apr 29, 2024

Thanks @erikgb, the change is great, but it should be merged into the release-next branch.

Updated the PR. PTAL!

@inteon
Copy link
Member

inteon commented Apr 29, 2024

/unhold
/lgtm
/approve

@cert-manager-prow cert-manager-prow bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 29, 2024
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2024
@cert-manager-prow cert-manager-prow bot merged commit 3b87d34 into cert-manager:release-next Apr 29, 2024
4 checks passed
@cert-manager-prow cert-manager-prow bot mentioned this pull request May 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inteon inteon Awaiting requested review from inteon

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikgb @inteon