Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported releases updates after cert-manager 1.17 #1636

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

SgtCoDFish
Copy link
Member

The supported k8s versions have always been quite manual, and this is my best effort at working out what makes sense for 1.18.

Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 3, 2025
Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for cert-manager ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 638cb0c
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager/deploys/67a106bd125e34000832d9d5
😎 Deploy Preview https://deploy-preview-1636--cert-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment on lines +215 to +219
| [EKS][eks] | 1.30 (Jul 2025) | 1.31 (Nov 2025), 1.32 (TBD) |
| [GKE][gke] | 1.30 (Jul 2025) | 1.31 (Sep 2025) |
| [AKS][aks] | 1.30 (Jul 2025) | 1.31 (Nov 2025), 1.32 (Mar 2026) |
| [OpenShift 4][os] | 1.28 (4.15, Aug 2025) | 1.29 (4.16, Dec 2025), 1.30 (4.17, Apr 2026) |
| [OpenShift 4 EUS][os] | 1.27 (4.14, Oct 2025) | 1.29 (4.16, Jun 2026) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating these is a pain. Thanks for doing it!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reviewing 😁

@@ -292,6 +292,7 @@ are no longer supported.

| Release | Release Date | EOL | Compatible Kubernetes versions | Compatible OpenShift versions |
|----------|:------------:|:------------:|:------------------------------:|:-----------------------------:|
| [1.15][] | Jun 05, 2024 | Feb 03, 2025 | 1.25 → 1.32 | 4.12 → 4.16 |
Copy link
Member

@maelvls maelvls Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems about right. I guess 1.24 -> 1.25 is because of some new requirement in cert-manager, but I know too little, I'll trust your judgement 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this changed for 1.15, right? It shouldn't have.

It moved from supported to the "no longer supported" section, the original was:

| [1.15][] | Jun 05, 2024 | Feb 03, 2025 | 1.25 → 1.32 / 4.12 → 4.16 | 1.25 → 1.31 |

So it should be the same?

Copy link
Member

@maelvls maelvls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2025
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2025
@SgtCoDFish SgtCoDFish merged commit a26bab5 into cert-manager:master Feb 4, 2025
7 checks passed
@SgtCoDFish SgtCoDFish deleted the supported-releases branch February 4, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants