Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(secret-wasm): Add permission check for message encryption #1290

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(secret-wasm): Add permission check for message encryption #1290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
126 changes: 56 additions & 70 deletions packages/background/src/secret-wasm/handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,122 +1,108 @@
import {
Env,
Handler,
InternalHandler,
KeplrError,
Message,
} from "@keplr-wallet/router";
import { Handler, InternalHandler, Env, Message } from "@keplr-wallet/router";
import { SecretWasmService } from "./service";
import { PermissionService } from "../permission";
import {
GetPubkeyMsg,
GetTxEncryptionKeyMsg,
IsNewApiMsg,
ReqeustEncryptMsg,
RequestDecryptMsg,
} from "./messages";
import { SecretWasmService } from "./service";
import { PermissionInteractiveService } from "../permission-interactive";

export const getHandler: (
service: SecretWasmService,
permissionInteractionService: PermissionInteractiveService
) => Handler = (service, permissionInteractionService) => {
return (env: Env, msg: Message<unknown>) => {
switch (msg.constructor) {
case GetPubkeyMsg:
return handleGetPubkeyMsg(service, permissionInteractionService)(
env,
msg as GetPubkeyMsg
);
case ReqeustEncryptMsg:
return handleReqeustEncryptMsg(service, permissionInteractionService)(
env,
msg as ReqeustEncryptMsg
);
case RequestDecryptMsg:
return handleRequestDecryptMsg(service, permissionInteractionService)(
env,
msg as RequestDecryptMsg
);
case GetTxEncryptionKeyMsg:
return handleGetTxEncryptionKeyMsg(
service,
permissionInteractionService
)(env, msg as GetTxEncryptionKeyMsg);
default:
throw new KeplrError("secret-wasm", 120, "Unknown msg type");
}
permissionService: PermissionService
) => Handler = (service, permissionService) => {
return {
getPubkey: handleGetPubkeyMsg(service, permissionService),
encrypt: handleReqeustEncryptMsg(service, permissionService),
decrypt: handleRequestDecryptMsg(service, permissionService),
getTxEncryptionKey: handleGetTxEncryptionKeyMsg(
service,
permissionService
),
isNewApi: handleIsNewApiMsg(service, permissionService),
};
};

const handleGetPubkeyMsg: (
service: SecretWasmService,
permissionInteractionService: PermissionInteractiveService
) => InternalHandler<GetPubkeyMsg> = (
service,
permissionInteractionService
) => {
return async (env, msg) => {
await permissionInteractionService.ensureEnabled(
permissionService: PermissionService
) => InternalHandler<GetPubkeyMsg> = (service, permissionService) => {
return async (env: Env, msg: GetPubkeyMsg & { origin: string }) => {
await permissionService.checkOrGrantBasicAccessPermission(
env,
[msg.chainId],
msg.chainId,
msg.origin
);

return await service.getPubkey(msg.chainId);
};
};

const handleIsNewApiMsg: (
service: SecretWasmService,
permissionService: PermissionService
) => InternalHandler<IsNewApiMsg> = (service, permissionService) => {
return async (env: Env, msg: IsNewApiMsg & { origin: string }) => {
await permissionService.checkOrGrantBasicAccessPermission(
env,
msg.chainId,
msg.origin
);

return await service.isNewApi(msg.chainId);
};
};

const handleReqeustEncryptMsg: (
service: SecretWasmService,
permissionInteractionService: PermissionInteractiveService
) => InternalHandler<ReqeustEncryptMsg> = (
service,
permissionInteractionService
) => {
return async (env, msg) => {
await permissionInteractionService.ensureEnabled(
permissionService: PermissionService
) => InternalHandler<ReqeustEncryptMsg> = (service, permissionService) => {
return async (env: Env, msg: ReqeustEncryptMsg & { origin: string }) => {
await permissionService.checkOrGrantBasicAccessPermission(
env,
msg.chainId,
msg.origin
);

await permissionService.checkOrGrantPermission(
env,
[msg.chainId],
"secret-wasm-encryption",
msg.origin
);

// TODO: Should ask for user whether approve or reject to encrypt.
return await service.encrypt(msg.chainId, msg.contractCodeHash, msg.msg);
};
};

const handleRequestDecryptMsg: (
service: SecretWasmService,
permissionInteractionService: PermissionInteractiveService
) => InternalHandler<RequestDecryptMsg> = (
service,
permissionInteractionService
) => {
return async (env, msg) => {
await permissionInteractionService.ensureEnabled(
permissionService: PermissionService
) => InternalHandler<RequestDecryptMsg> = (service, permissionService) => {
return async (env: Env, msg: RequestDecryptMsg & { origin: string }) => {
await permissionService.checkOrGrantBasicAccessPermission(
env,
[msg.chainId],
msg.chainId,
msg.origin
);

// XXX: Is there need to ask for user whether approve or reject to decrypt?
return await service.decrypt(msg.chainId, msg.cipherText, msg.nonce);
};
};

const handleGetTxEncryptionKeyMsg: (
service: SecretWasmService,
permissionInteractionService: PermissionInteractiveService
) => InternalHandler<GetTxEncryptionKeyMsg> = (
service,
permissionInteractionService
) => {
return async (env, msg) => {
await permissionInteractionService.ensureEnabled(
permissionService: PermissionService
) => InternalHandler<GetTxEncryptionKeyMsg> = (service, permissionService) => {
return async (env: Env, msg: GetTxEncryptionKeyMsg & { origin: string }) => {
await permissionService.checkOrGrantBasicAccessPermission(
env,
[msg.chainId],
msg.chainId,
msg.origin
);

// XXX: Is there need to ask for user whether approve or reject to getting tx encryption key?
return await service.getTxEncryptionKey(msg.chainId, msg.nonce);
};
};