Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: BTC vault deposit electoral system #5640

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

marcellorigotti
Copy link
Contributor

@marcellorigotti marcellorigotti commented Feb 14, 2025

Pull Request

Closes: PRO-2029

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

Vault deposit witnessing ES for Bitcoin.
Use a different instance of the same electoral system to handle different witnesses:

  • one for deposit channel
  • one for vaults
  • one for egress
  • etc...

This allow us to keep the election votes small and possibly to only pause/unpause specific function of the witnessing.

@marcellorigotti marcellorigotti requested review from MxmUrw and removed request for dandanlen and kylezs February 14, 2025 10:05
@kylezs kylezs self-requested a review February 14, 2025 10:20
@marcellorigotti marcellorigotti marked this pull request as ready for review February 19, 2025 14:13
@@ -96,19 +96,6 @@ pub trait BWProcessorTypes: Sized {
+ 'static;
type BlockData: PartialEq + Clone + Debug + Eq + Serde + 'static;

// type ChainBlockNumber: Serde
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@marcellorigotti marcellorigotti merged commit 53c2852 into feat/block-witnesser-es Feb 19, 2025
1 check passed
@marcellorigotti marcellorigotti deleted the feature/pro-2029 branch February 19, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants