-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: BTC vault deposit electoral system #5640
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylezs
reviewed
Feb 17, 2025
kylezs
reviewed
Feb 18, 2025
c70b94a
to
f31ef3a
Compare
a1c974a
to
9a75cb0
Compare
9a75cb0
to
2c30c0b
Compare
kylezs
approved these changes
Feb 19, 2025
@@ -96,19 +96,6 @@ pub trait BWProcessorTypes: Sized { | |||
+ 'static; | |||
type BlockData: PartialEq + Clone + Debug + Eq + Serde + 'static; | |||
|
|||
// type ChainBlockNumber: Serde |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-2029
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Vault deposit witnessing ES for Bitcoin.
Use a different instance of the same electoral system to handle different witnesses:
This allow us to keep the election votes small and possibly to only pause/unpause specific function of the witnessing.