fix: pick hotfixes from 1.8 branch #5645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandanlen
changed the title
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
|
Looks like it's waiting for 1.8.2 to be tagged before it can build... |
dandanlen
force-pushed
the
feat/cherry-picks-from-1.8
branch
from
e62b4ba to
312ab4b
Compare
|
The stuck fetches fix is already on main: #5632 |
True - looks like that commit only contains changelog updates and a version bump. I'll change the label. |
dandanlen
force-pushed
the
feat/cherry-picks-from-1.8
branch
from
312ab4b to
4ca46b5
Compare
kylezs
approved these changes
Feb 20, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 20, 2025
* fix: delete Solana channel state when closed * chore: CHANGELOG and a version bump * test: invalid fetches should not block valid fetches * fix: only decrement counter if we can actually fetch * feat: add account id / withdrawal address to affiliate events (#5634) * feat: Added broker_id to WithdrawalRequest event * chore: changed broker_id to account_id I think this is a better name since it could be either a broker or an affiliate but in the end both is an account. * feat: Added withdrawal address to AffiliateRegistration * feat: returning detailed account information for affiliate in the cf_account_info rpc for brokers (#5641) * feat: Added asset_balances to Unregistered Account variant * chore: added deprecate note * fix: simplify asset map conversion * feat: add optional affiliate withdrawal address to broker account info * fix: clippy and test * fix: make BrokerInfo non-breaking * fix: unused import --------- Co-authored-by: Daniel <daniel@chainflip.io> * fix: ensure correct affiliate account creation/removal * fix: typo * fix: missing version bumps --------- Co-authored-by: kylezs <kyle@chainflip.io> Co-authored-by: Janislav <jan@chainflip.io>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
* test: invalid fetches should not block valid fetches * fix: only decrement counter if we can actually fetch
* feat: Added broker_id to WithdrawalRequest event * chore: changed broker_id to account_id I think this is a better name since it could be either a broker or an affiliate but in the end both is an account. * feat: Added withdrawal address to AffiliateRegistration
…account_info rpc for brokers (#5641) * feat: Added asset_balances to Unregistered Account variant * chore: added deprecate note * fix: simplify asset map conversion * feat: add optional affiliate withdrawal address to broker account info * fix: clippy and test * fix: make BrokerInfo non-breaking * fix: unused import --------- Co-authored-by: Daniel <daniel@chainflip.io>
dandanlen
force-pushed
the
feat/cherry-picks-from-1.8
branch
from
ae04639 to
91e6382
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picks recent fixes from release/1.8