feat: ETH broker level screening support #5663
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
Janislav
changed the title
dandanlen
reviewed
Feb 22, 2025
| @@ -747,6 +747,9 @@ pub mod pallet { | |||
| TransactionRejectionFailed { | |||
| tx_id: <T::TargetChain as Chain>::DepositDetails, | |||
| }, | |||
| DebugEvent { | |||
There was a problem hiding this comment.
Reminder to remove this.
Comment on lines
+1795
to
+1797
| let tx_id = tx_ids | ||
| .first() | ||
| .expect("there must be exactly one tx_id for a prewitnessed deposit."); |
There was a problem hiding this comment.
We should check all the ids: for tx_id in tx_ids...
There was a problem hiding this comment.
But we only prewitness for BTC, and there is only one.
There was a problem hiding this comment.
If we have more than one, then there is something fishy going on
… "origin/feature/eth-broker-level-screnning"
dandanlen
force-pushed
the
feature/eth-broker-level-screnning
branch
from
8693d72 to
c1ab0ac
Compare
+ Using 11 account + refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-xxx
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Please include a succinct description of the purpose and content of the PR. What problem does it solve, and how? Link issues, discussions, other PRs, and anything else that will help the reviewer.