README: Fix Delete example
#112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like this was accidentally left as a copy-paste of the `Assign`
example. I took the liberty to add some extra keys to the object which
we're deleting from, as I think it makes it a bit clearer what's
happening than:
{ "secret": { "universe": 42 }} -> { "secret": {} }
Which confused me a bit at first (but that might just be me).
asmello
approved these changes
Feb 26, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
|
I guess semver will continue failing until we make a new release. @chanced Since this is fairly uncontroversial I'll go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like this was accidentally left as a copy-paste of the
Assignexample. I took the liberty to add some extra keys to the object which we're deleting from, as I think it makes it a bit clearer what's happening than:Which confused me a bit at first (but that might just be me).