Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds position to AssignError, ResolveError variants, renames both errors to be less redundant #93

Closed
wants to merge 15 commits into from
Closed

Adds position to AssignError, ResolveError variants, renames both errors to be less redundant #93

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
45c4fde
* Renames `crate::resolve::ResolveError` to `crate::resolve::Error`
chanced Oct 21, 2024
e892a48
rename SlicePointer --> PointerIndex (#92)
asmello Oct 22, 2024
5dbf330
Improve `ParseIndexError::InvalidCharacter` error (#94)
asmello Oct 29, 2024
0b60a5c
adds ParseBufError, report::{Report,IntoReport,Subject,ReportErr}
chanced Nov 9, 2024
b48e05b
adds `Index` link to in docs
chanced Nov 9, 2024
16731e1
impls `miette::Diagnostic` for `Report`
chanced Nov 14, 2024
78704a4
refactoring
chanced Nov 14, 2024
1845e56
finishes up this round of the implementation - forgot a few things ea…
chanced Nov 14, 2024
8699be5
test now properly shows the fancy error display
chanced Nov 14, 2024
f69fa55
`Diagnostic::label` -> `Diagnostic::labels`
chanced Nov 15, 2024
112fec5
improves parse error & adds a quick spike test to see miette formatti…
chanced Nov 15, 2024
b78f2a6
Update CHANGELOG.md
chanced Nov 15, 2024
516e9b3
cleans up parse error message
chanced Nov 15, 2024
8550151
resolves a couple of review items
chanced Nov 15, 2024
f507257
impls miette::Report for RichParseError
chanced Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,24 +5,25 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).


## [Unreleased]

### Added

- Adds method `into_buf` for `Box<Pointer>` and `impl From<PathBuf> for Box<Pointer>`.
- Adds method `into_buf` for `Box<Pointer>` and `impl From<PathBuf> for Box<Pointer>`.
- Adds unsafe associated methods `Pointer::new_unchecked` and `PointerBuf::new_unchecked` for
external zero-cost construction.
- Adds `Pointer::starts_with` and `Pointer::ends_with` for prefix and suffix matching.
- Adds new `ParseIndexError` variant to express the presence non-digit characters in the token.
- Adds `Token::is_next` for checking if a token represents the `-` character.
- Adds `ParseBufError`, returned as the `Err` side of `PointerBuf::parse`, which includes the input `String`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Adds `ParseBufError`, returned as the `Err` side of `PointerBuf::parse`, which includes the input `String`.
- Adds `ParseBufError`, returned as the `Err` variant of `PointerBuf::parse`, which includes the input `String`.

Also, I'm not sure about the String part since the input can be another type.

Copy link
Owner Author

@chanced chanced Nov 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I wasn't sure how to express "the result of the call to Into::into<String>(&input)" without it being so verbose.


### Changed

- Changed signature of `PathBuf::parse` to avoid requiring allocation.
- Bumps minimum Rust version to 1.79.
- `Pointer::get` now accepts ranges and can produce `Pointer` segments as output (similar to
`slice::get`).
- `PointerBuf::parse` now returns `BufParseError` instead of `ParseError`.

### Fixed

Expand Down
Loading