feat: allow for overwritting the cookie-domain flag on the oidc proxy #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
CCIE-3528-conditional-logic-around-the-ingress-yml-to-point-to-the-service-or-the-oauth-2-proxy-service
to
CCIE-3526-add-upstream-flags-to-the-oauth-2-proxy-deployment
October 25, 2024 16:43
Base automatically changed from
CCIE-3526-add-upstream-flags-to-the-oauth-2-proxy-deployment
to
CCIE-3527-add-the-skip-auth-values-to-the-skip-auth-flags-of-the-oauth-2-proxy-deployment
October 25, 2024 16:43
Base automatically changed from
CCIE-3527-add-the-skip-auth-values-to-the-skip-auth-flags-of-the-oauth-2-proxy-deployment
to
main
October 25, 2024 17:02
…n-and-logout-behavior-for-vcp
naihsuanshao
approved these changes
Oct 25, 2024
abiju-czi
approved these changes
Oct 25, 2024
jakeyheath
deleted the
CCIE-3548-enable-login-and-logout-behavior-for-vcp
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://czi.atlassian.net/browse/VC-1158
Summary
Some folks require that the cookie be set on a different domain other than the default domain argus provides and the domains that are used to host the application. For example, some applications need to be able to set the cookie on a parent domain so it can be easily shared with other subdomains.
The following configuration will overwrite the default
--cookie-domainflag withmyproddomain.com:Subdomains of myproddomain.com will have access to this cookie.