Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: trailing slash on upstreams #159

Merged
merged 2 commits into from
Oct 25, 2024
Merged

fix: trailing slash on upstreams #159

merged 2 commits into from
Oct 25, 2024

Conversation

jakeyheath
Copy link
Contributor

@jakeyheath jakeyheath commented Oct 25, 2024 •
edited
Loading

Summary

All the upstreams need a trailing slash to simulate the pathprefix routing type. Checks if it is using "Exact" path type and omits the trailing slash.

Reference

@jakeyheath jakeyheath enabled auto-merge (squash) October 25, 2024 18:35
@jakeyheath jakeyheath merged commit ed0ef29 into main Oct 25, 2024
13 checks passed
@jakeyheath jakeyheath deleted the jakeyheath-patch-1 branch October 25, 2024 18:37
@czi-github-helper czi-github-helper bot mentioned this pull request Oct 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naihsuanshao naihsuanshao naihsuanshao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakeyheath @naihsuanshao