Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed whitespace for adding annotations #187

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

naihsuanshao
Copy link
Contributor

Currently adding annotation for eks role for cronjob is wrong, see here.

annotations:
  eks.amazonaws.com/role-arn: 'arn:aws:iam::471112759938:role/argo_root_core_platform_infra_dev_eks'
apiVersion: v1
automountServiceAccountToken: true
kind: ServiceAccount
metadata:
  labels:
    app.kubernetes.io/instance: argus-rdev-e54afa8b
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: stack
    app.kubernetes.io/service: argus-rdev-e54afa8b-stack-syncawssecretmanager
    app.kubernetes.io/version: 1.16.0
    argocd.argoproj.io/instance: argus-rdev-e54afa8b
    helm.sh/chart: stack-2.5.2
  name: argus-rdev-e54afa8b-stack-syncawssecretmanager
  namespace: core-platform-rdev

Fixed this bug and added new unit tests.

@naihsuanshao naihsuanshao merged commit 848ac28 into main Jan 22, 2025
14 checks passed
@naihsuanshao naihsuanshao deleted the nshao/fix-white-space-for-cronjob branch January 22, 2025 17:42
@czi-github-helper czi-github-helper bot mentioned this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants