feat: allow specifying init container tag in Stack helm chart #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hspitzley-czi
requested review from
jakeyheath
and removed request for
jakeyheath
jakeyheath
approved these changes
Jun 20, 2024
support backwards compatibility (it's only used by the example app right now so we could change it to not have to support both) |
hspitzley-czi
deleted the
CCIE-2951-stack-helm-chart-to-allow-specifying-init-container-tag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to continue specifying the image as a string formatted like
<repo>:<tag>and also adds support to allow us to specify repo and tag as separate tags, allowing theargus-docker-builderaction to replace the tag with the sha that it just built.Specifying as a string
Rendered manifest:
Specifying as an object
Rendered manifest:
