Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (CCIE-3082) add unit testing to GHA #64

Merged
merged 9 commits into from
Aug 1, 2024
Merged

feat: (CCIE-3082) add unit testing to GHA #64

merged 9 commits into from
Aug 1, 2024

Conversation

dtsai-czi
Copy link
Contributor

@dtsai-czi dtsai-czi commented Jul 30, 2024

enable helm-unittest GHA, individual tests to follow

@dtsai-czi dtsai-czi requested a review from hspitzley-czi August 1, 2024 17:16
@dtsai-czi dtsai-czi marked this pull request as ready for review August 1, 2024 17:17
Comment on lines 6 to 7
values:
- values.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use set instead of values for this test so we can just get a minimal test running

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed now, right?

Copy link
Contributor

@hspitzley-czi hspitzley-czi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

@dtsai-czi dtsai-czi merged commit 8d332f7 into main Aug 1, 2024
2 checks passed
@dtsai-czi dtsai-czi deleted the unittest branch August 1, 2024 18:19
@czi-github-helper czi-github-helper bot mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants