feat: add pvc creation support #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hayden Spitzley <105455169+hspitzley-czi@users.noreply.github.com>
added 2 commits
August 1, 2024 13:05
…nzuckerberg/argo-helm-charts into GPU-271/pvc-creation-support
stack/templates/pvc.yaml
Outdated
Comment on lines
21
to
23
| {{- range .Values.persistence.accessModes }} | ||
| - {{ . | quote }} | ||
| {{- end }} |
There was a problem hiding this comment.
Can this be simplified to use toYaml?
There was a problem hiding this comment.
agreed, maybe just allow the user to specify a spec and toYaml it. That way we don't have to keep adding prs to support other features and the configuration looks more like natural k8s configuration
Co-authored-by: Hayden Spitzley <105455169+hspitzley-czi@users.noreply.github.com>
Co-authored-by: Hayden Spitzley <105455169+hspitzley-czi@users.noreply.github.com>
jakeyheath
approved these changes
Aug 1, 2024
|
@jakeyheath @hspitzley-czi Thank you for the feedback. I opened all the pvc settings and linted the chart |
hspitzley-czi
approved these changes
Aug 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the option for users to create pvc claims