Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin goimports and gopy versions #322

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

lvreynoso
Copy link
Contributor

@lvreynoso lvreynoso commented Feb 6, 2024

Fixes an issue where new builds of the short-read-mngs Docker image fail if they aren't using cached versions of the s3quilt stage due to updated dependencies in the latest versions of goimports and gopy.

@lvreynoso lvreynoso marked this pull request as ready for review February 7, 2024 17:10
@lvreynoso lvreynoso requested a review from morsecodist February 7, 2024 17:10
@lvreynoso
Copy link
Contributor Author

After discussion between @morsecodist we have decided to merge this PR despite the failing short-read-mngs viral benchmarks / run-samples CI action since we could not reproduce the failure locally. Pulling http://ghcr.io/chanzuckerberg/czid-workflows/czid-short-read-mngs-public:56fbf4b and running the test locally worked.

@lvreynoso lvreynoso merged commit db8468e into main Feb 9, 2024
13 of 15 checks passed
@lvreynoso lvreynoso deleted the lvreynoso/pin_s3quilt_reqs branch February 9, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant