Add Aurora deletion protection variable (#116)

* Make db cluster parameter group configurable * Add Aurora's database deletion protection * Remove prev WIP * Add back db parameter * Default deletion protection to false * Deletion back to true by default, fix test * Add default value to aws-aurora module * Test changing var name * Revert name change, make test hung up * Fix tests
chanzuckerberg · Sep 12, 2019 · ddf566a · ddf566a
1 parent 384ed74
commit ddf566a
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 0 deletions.
diff --git a/aws-aurora-mysql/main.tf b/aws-aurora-mysql/main.tf
@@ -13,6 +13,7 @@ module "aurora" {
   database_password                   = "${var.database_password}"
   database_username                   = "${var.database_username}"
   db_parameters                       = "${var.db_parameters}"
+  db_deletion_protection              = "${var.db_deletion_protection}"
   rds_cluster_parameters              = "${var.rds_cluster_parameters}"
   iam_database_authentication_enabled = "${var.iam_database_authentication_enabled}"
   performance_insights_enabled        = "${var.performance_insights_enabled}"

diff --git a/aws-aurora-mysql/variables.tf b/aws-aurora-mysql/variables.tf
@@ -150,3 +150,8 @@ variable "iam_database_authentication_enabled" {
   type    = "string"
   default = false
 }
+
+variable "db_deletion_protection" {
+  type    = "string"
+  default = false
+}
diff --git a/aws-aurora/main.tf b/aws-aurora/main.tf
@@ -51,6 +51,7 @@ resource "aws_rds_cluster" "db" {
   kms_key_id                          = "${var.kms_key_id}"
   port                                = "${var.port}"
   db_cluster_parameter_group_name     = "${aws_rds_cluster_parameter_group.db.id}"
+  deletion_protection                 = "${var.db_deletion_protection}"
 
   enabled_cloudwatch_logs_exports = "${var.enabled_cloudwatch_logs_exports}"
 

diff --git a/aws-aurora/variables.tf b/aws-aurora/variables.tf
@@ -112,3 +112,8 @@ variable "performance_insights_enabled" {
   type    = "string"
   default = true
 }
+
+variable "db_deletion_protection" {
+  type    = "string"
+  default = false
+}