Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add aws-redis-replication-group #267

Merged
merged 8 commits into from
Jan 8, 2021

Conversation

davidrissato
Copy link
Contributor

@davidrissato davidrissato commented Dec 10, 2020

Summary

This module is similar to aws-redis-node, however it creates a Elasticache Redis cluster using a replication group.
The motivation to create this module is because encryption options (in-transit and at rest) are only available when you create your cluster using a replication group.

Test Plan

  • Manual tests (already applied to IDseq)
  • Unit tests

References

(Optional) Additional links to provide more context.

@davidrissato davidrissato changed the title [Feature] Add aws-redis-replication-group [feature] Add aws-redis-replication-group Dec 23, 2020
@davidrissato davidrissato force-pushed the davidrc/redis-replication-group branch from afb9cea to ffcdf92 Compare December 23, 2020 19:43
@davidrissato davidrissato marked this pull request as ready for review December 23, 2020 20:21
Copy link
Contributor

@ryanking ryanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module needs to be added to the list in the ci.yml in order to run the tests in CI.

@czimergebot czimergebot merged commit 1b53806 into main Jan 8, 2021
@czimergebot czimergebot deleted the davidrc/redis-replication-group branch January 8, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants