[fix] Various fixes for TF AWS 3.0 compatibility #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cziie
reviewed
Jul 8, 2021
| @@ -30,7 +30,7 @@ resource "aws_lb_target_group" "service" { | |||
| resource "aws_lb" "service" { | |||
There was a problem hiding this comment.
Missing version constraint for provider "aws" in "required_providers"
cziie
reviewed
Jul 8, 2021
| @@ -56,7 +56,7 @@ resource "aws_elasticache_cluster" "default" { | |||
| num_cache_nodes = 1 | |||
| parameter_group_name = var.parameter_group_name | |||
There was a problem hiding this comment.
📝 [tflint] reported by reviewdog 🐶
"default.redis5.0" is default parameter group. You cannot edit it.
mbarrien
commented
Jul 8, 2021
| @@ -87,7 +87,7 @@ resource "aws_s3_bucket_public_access_block" "bucket" { | |||
| module "security_headers_lambda" { | |||
| source = "../aws-lambda-edge-add-security-headers" | |||
|
|
|||
| function_name = replace("${local.website_fqdn}-static-site-security-headers", ".", "-") | |||
| function_name = replace("${local.website_fqdn}-headers", ".", "-") | |||
There was a problem hiding this comment.
Reduce issue where this string is >64 characters long. Forces redeploy of lambda for anything already deployed with HSTS headers (which should just be a single deployment in Along), and the redeploy should be safe.
* Shorten static site lambda name * Remove unneeded bare aws provider from static site * Fix aws-ssm-params readme * Upgrade terraform-aws-modules/security-group/aws for TF 3.0 compatiblity * aws-lambda-functionaws_cloudwatch_log_group use ARN instead of manually constructing since ARN is fixed in TF AWS 3.0 * Update readmes via make docs
mbarrien
force-pushed
the
tf-aws-3.0-fixes
branch
from
3683c45 to
eb30ace
Compare
cziie
reviewed
Jul 8, 2021
| @@ -81,14 +81,6 @@ data "aws_region" "current" {} | |||
| data "aws_caller_identity" "current" {} | |||
There was a problem hiding this comment.
data "aws_caller_identity" "current" is declared but not used
alexsmaliy-czi
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
constructing since ARN is fixed in TF AWS 3.0