fix(sdstheme): fix SDS Theme backward compatibility

chanzuckerberg · May 3, 2024 · 02398da · 02398da
1 parent d70cd2d
commit 02398da
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 5 deletions.
diff --git a/packages/components/src/core/styles/common/SDSAppTheme.ts b/packages/components/src/core/styles/common/SDSAppTheme.ts
@@ -76,6 +76,9 @@ export const SDSAppTheme: AppTheme = {
     s: 2,
   },
   fontWeights: {
+    bold: 700,
+    light: 300,
+    medium: 800,
     regular: 400,
     semibold: 600,
   },
@@ -378,6 +381,15 @@ export const SDSAppTheme: AppTheme = {
   },
 };
 
+/**
+ * (masoudmanson): This is to make sure that the old defaultAppTheme
+ * export is still available for backward compatibility.
+ *
+ * @deprecated
+ * Please use `SDSAppTheme` instead. This export will be removed in the future.
+ */
+export const defaultAppTheme = SDSAppTheme;
+
 // (mlila) whenever our theme uses colors, we need to make sure we allow consuming
 // applications to override those colors using their own custom theme.
 // By defining borders using SDSAppTheme.colors instead of defaultThemeColors,

diff --git a/packages/components/src/core/styles/common/defaultTheme.ts b/packages/components/src/core/styles/common/defaultTheme.ts
@@ -6,8 +6,3 @@ import { makeThemeOptions } from "./makeThemeOptions";
 const defaultThemeOptions: SDSThemeOptions = makeThemeOptions(SDSAppTheme);
 
 export const defaultTheme = createTheme(defaultThemeOptions);
-
-/**
- * (masoudmanson): This is to keep the old defaultAppTheme export for backward compatibility.
- */
-export const defaultAppTheme = defaultTheme;
diff --git a/packages/components/src/core/styles/common/types.ts b/packages/components/src/core/styles/common/types.ts
@@ -248,6 +248,9 @@ export interface Typography {
 }
 
 export interface FontWeights {
+  bold: number;
+  light: number;
+  medium: number;
   regular: number;
   semibold: number;
 }