Skip to content

Commit

Permalink
fix(callout): added comment to code to explain change
Browse files Browse the repository at this point in the history
Specified why I made the change I did and pointed to the GH ticket for context

re #578
  • Loading branch information
liaprins committed Jan 12, 2024
1 parent 3980bbb commit 2cb1613
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/components/src/core/Callout/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ const Callout = ({
};

const getIcon = () => {
if (icon !== undefined) return icon;
if (icon !== undefined) return icon; // (liaprins): Explicitly use `icon !== undefined` to fix bug; see ticket for context: https://github.com/chanzuckerberg/sci-components/issues/577

switch (intent) {
case "success":
Expand Down

0 comments on commit 2cb1613

Please sign in to comment.