Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Controlled InputToggle #760

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Conversation

tihuan
Copy link
Contributor

@tihuan tihuan commented Apr 5, 2024

Summary

  1. Add controlled state to InputToggle
  2. Add Controlled story and default checked to true
Screen.Recording.2024-04-05.at.2.11.32.PM.mov

Structural Element (Base, Gene, DNA, Chromosome or Cell)
Github issue: #XXXX
Copy issue description here

Checklist

  • Default Story in Storybook
  • LivePreview Story in Storybook
  • Test Story in Storybook
  • Tests written
  • Variables from defaultTheme.ts used wherever possible
  • If updating an existing component, depreciate flag has been used where necessary
  • Chromatic build verified by @chanzuckerberg/sds-design

@tihuan tihuan requested review from masoudmanson and aganders3 April 5, 2024 21:13
@tihuan tihuan force-pushed the thuang-controlled-InputToggle branch from 8df5c90 to aa143fa Compare April 5, 2024 22:06
Copy link
Contributor

@masoudmanson masoudmanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @tihuan 🥳🤩
Thank you for taking the time and fixing the bug. I'll merge this into the main branch and publish it on Wednesday with the rest of new features 🎉

@masoudmanson masoudmanson merged commit 3f79600 into main Apr 9, 2024
10 checks passed
@masoudmanson masoudmanson deleted the thuang-controlled-InputToggle branch April 9, 2024 00:06
@tihuan
Copy link
Contributor Author

tihuan commented Apr 15, 2024

I'm back!! Thanks so much for taking care of the release of this PR, @masoudmanson 🤩 🙏 !!

@masoudmanson
Copy link
Contributor

I'm back!! Thanks so much for taking care of the release of this PR, @masoudmanson 🤩 🙏 !!

Yaaay! Welcome back @tihuan 🥳🤩🎉 Happy to help 🥸🤩🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants