Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inputs): fix intent prop type #899

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix(inputs): fix intent prop type #899

merged 1 commit into from
Nov 19, 2024

Conversation

masoudmanson
Copy link
Contributor

Summary

InputCheckbox, InputRadio
Github issue: #898

Checklist

  • Default Story in Storybook
  • LivePreview Story in Storybook
  • Test Story in Storybook
  • Tests written
  • Variables from defaultTheme.ts used wherever possible
  • If updating an existing component, depreciate flag has been used where necessary
  • Chromatic build verified by @chanzuckerberg/sds-design

@masoudmanson masoudmanson added Bug Something isn't working P0 Eng labels Nov 19, 2024
@masoudmanson masoudmanson self-assigned this Nov 19, 2024
@masoudmanson masoudmanson linked an issue Nov 19, 2024 that may be closed by this pull request
Fix intent type in InputCheckbox and InputRadio components #898
Closed
@masoudmanson masoudmanson requested a review from tihuan November 19, 2024 20:10
@masoudmanson masoudmanson added the Ready for review This PR is ready for review label Nov 19, 2024
tihuan
tihuan approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you!!

@tihuan tihuan merged commit 064f1b4 into main Nov 19, 2024
10 checks passed
@masoudmanson masoudmanson deleted the 898-fix-intent-type-in-inputcheckbox-and-inputradio-components branch November 20, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tihuan tihuan tihuan approved these changes

Assignees

@masoudmanson masoudmanson

Labels
Bug Something isn't working Eng P0 Ready for review This PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix intent type in InputCheckbox and InputRadio components
2 participants
@masoudmanson @tihuan