Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing tciFree #25974

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Add missing tciFree #25974

merged 1 commit into from
Sep 24, 2024

Conversation

jhh67
Copy link
Contributor

@jhh67 jhh67 commented Sep 23, 2024

Added missing tciFree to chpl_comm_ensure_progress.

@jhh67
Add missing tciFree
23a0fdb 
Signed-off-by: John H. Hartman <jhh67@users.noreply.github.com>
@jhh67 jhh67 merged commit 71ddda0 into chapel-lang:main Sep 24, 2024
7 checks passed
@jhh67 jhh67 deleted the tciFree branch September 24, 2024 19:49
@bradcray
Copy link
Member

What's the impact of this PR? What's the impact of 2.2 not having it?

@jhh67
Copy link
Contributor Author

jhh67 commented Sep 25, 2024

CHPL_COMM=ofi with unbound endpoints will run out of them and hang. Endpoints are unbound when there are fewer endpoints than the number of worker threads + 2. I'm not aware of any realistic configuration in which this occurs, I have to limit the number of endpoints artificially during testing to get them to be unbound, which is how I came across this bug. I have a test of non-blocking PUTs with unbound endpoints in PR #25977, so going forward we'll have at least some testing of unbound endpoints.

@bradcray
Copy link
Member

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jabraham17 jabraham17 jabraham17 approved these changes

Assignees

@jabraham17 jabraham17

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhh67 @bradcray @jabraham17