dyno: Fix bugs that were breaking chpl-language-server tests #26007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Longnecker <dlongnecke-cray@users.noreply.github.com>
Signed-off-by: David Longnecker <dlongnecke-cray@users.noreply.github.com>
dlongnecke-cray
changed the title
|
@mppf Daniel pointed out some logic bugs that I should fix first before I ping you for review. |
Signed-off-by: David Longnecker <dlongnecke-cray@users.noreply.github.com>
mppf
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bugs that were causing test failures in
chpl-language-server.Make sure to skip resolving function bodies in
resolveFunctionif the function does not have one (e.g., forexternfunctions).If
typedSignatureInitialis called on a nested function and parent frames are not present, emit a warning and continue if the parent(s) are generic instead of returningnullptr. Future work should maketypedSignatureInitialtake the parent function signature instead.Reviewed by @mppf. Thanks!
TESTING
linux64,standardtest-chpl-language-server