add blog dirs to nightly testdirs more generally #26057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmad Rezaii <ahmad.rezaii@hpe.com>
riftEmber
approved these changes
Oct 8, 2024
Signed-off-by: Ahmad Rezaii <ahmad.rezaii@hpe.com>
good catch! I want that to work still so I added it back to the test condition |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands the cases when we add the blog directories to the list of directories to test. The change is to stop using the presence of
-exampleswith-blogto selectively add the blog directories, and instead just add them whenever-blogis used and thetestdirsvar already has some values in it. It should avoid the problem found in GPU tests and other configs that just populateCHPL_NIGHTLY_TEST_DIRSrather than callingnightlywith a specific set of flags.[reviewed by @riftEmber - thanks!]