Handle two issues that came up after some AVE improvements #26629

e-kayrakli · 2025-01-30T23:56:53Z

This PR handles two things:

Trivially: adds/updates good files that were missed in my initial PR.
More seriously: thwarts optimization when the rhs is a constant, multidimensional array. This is done to work around Non-inlined parallel iterators with const ref intent may lead to wrong results #26626. When that issue is resolved, the relevant commit can be reverted.

Test:

Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>

e-kayrakli added 2 commits January 29, 2025 09:50

Fix and add forgotten good files

19493a1

Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>

Workaround an issue by avoiding optimizing const, multid arrays

fd5521c

Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>

e-kayrakli requested a review from benharsh January 31, 2025 00:00

e-kayrakli mentioned this pull request Jan 31, 2025

Non-inlined parallel iterators with const ref intent may lead to wrong results #26626

Open

benharsh approved these changes Jan 31, 2025

View reviewed changes

e-kayrakli merged commit c56bdec into chapel-lang:main Jan 31, 2025
8 checks passed

e-kayrakli deleted the ave-dist-local-fallout branch January 31, 2025 01:12

Provide feedback