Fix a bug in the runtime when sbatch is used #26772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
|
@e-kayrakli : Does this resolve @jhh67 's https://github.com/Cray/chapel-private/issues/7152? |
Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
riftEmber
approved these changes
Feb 25, 2025
|
@riftEmber -- No worries. It is C's bad, really unmaintainable to do anything with strings in C. @bradcray -- John suggests checking other launchers, and Anna reported that she did take a look. I grepped a bit, found a couple of launchers where a similar pattern appears, but they all look right to me. I believe that's sufficient to close that issue. I'll add it to the OP so that it auto-closes. Let me know if you disagree. |
|
Thanks for the quick-fix here, Engin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
CHPL_LAUNCHER_USE_SBATCH, we have to compute some file names. Apparently there's a bug seeped in into that code that showed up as failures in our XC testing. The bug is about using strlen on memory that's zeroed out. This PR stores the string's size in a variable and uses that variable instead ofstrlening all zeros.At a high level, this bug shows that it would be good to have our launchers implemented in python as they are basically string manipulations, where C is not... very strong.
Closes https://github.com/Cray/chapel-private/issues/7152