Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude versionButton.php from rsync command #26777

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

arezaii
Copy link
Collaborator

@arezaii arezaii commented Feb 25, 2025

This updates the GHCI workflow to stop deleting the versionButton.php file on the remote side.

Since #26670 removed versionButton.php, rsync wants to delete it now since it doesn't exist on the source side. This adds an exclude option to the rsync command to ignore it.

Signed-off-by: Ahmad Rezaii <ahmad.rezaii@hpe.com>
@arezaii arezaii force-pushed the exclude-versionButton-rsync branch from d2f4cd7 to 6e504a6 Compare February 25, 2025 18:08
@arezaii arezaii merged commit 3f47cfd into chapel-lang:main Feb 25, 2025
9 checks passed
@bradcray
Copy link
Member

This seems surprising to me since #26670 didn't remove the file, it just changed it into a symbolic link (and that link should be rsync'd over with the rest of the docs, as the current publish-module-docs job is doing).

Could an rsync -l be what's needed here to preserve the symbolic link on the rsync rather than following it? (assuming there are no other symbolic links that we're relying on following during the rsync… If there are, we'll probably need to break this into two rsync commands?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants