Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added test for rune error #356

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

added test for rune error #356

wants to merge 1 commit into from

Conversation

LukaJaj
Copy link

@LukaJaj LukaJaj commented Jun 27, 2022

I added test for rune decoding error. is it ok way to mock ?

@LukaJaj LukaJaj mentioned this pull request Jun 27, 2022
Closed
@muesli
Copy link
Contributor

muesli commented Oct 11, 2022

I have no issue with mocking, but I'm wondering if this is really required here. Couldn't we just supply readInputs with an actual invalid input?

@LukaJaj
Copy link
Author

LukaJaj commented Oct 12, 2022

Correct, but reason we need to mock is utf8.DecodeRune() function since it requires utf8 (external) package

@aymanbagabas aymanbagabas deleted the branch charmbracelet:main October 28, 2024 17:41
@meowgorithm meowgorithm reopened this Oct 28, 2024
@meowgorithm meowgorithm changed the base branch from master to main October 28, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meowgorithm meowgorithm Awaiting requested review from meowgorithm meowgorithm is a code owner

@aymanbagabas aymanbagabas Awaiting requested review from aymanbagabas aymanbagabas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LukaJaj @muesli @meowgorithm @aymanbagabas @Jajanidze