-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add gh actions to publish canary versions [gh-0] #629
Conversation
The verison of this I have experience with also appends the commit hash on the end, so yuo end up wtih version's like Check out:
Also I would definitely recommend including the exact package name in the slack message that's posted / potentially also comment on the PR (See: https://github.com/nextauthjs/next-auth/blob/main/.github/workflows/release.yml#L114) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some formatting and version number comments, but looks really good so far!
Also, just somethign to think about - Instead of running it on a See: https://github.com/nextauthjs/next-auth/blob/main/.github/workflows/release.yml#L90
|
🎉 Experimental release successfully published on npm
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 🥳
I can't see the package-lock.json
changes in the Github UI, too big 😅. However, its a bit fishy to me that it's that many changes.. You only added oclif
as a dev dependency, right? Hmm..
Is the package-lock.json
format maybe updated from v1
to v2
here by accident?
I hereby confirm that I followed the code guidelines found at engineering guidelines
Affected Components
Notes for the Reviewer
build
label is added to the PR<packageVersion>.-canary-<prNumber>.<shortSha>
and tagcanary-<prNumber>
Note: if you want to re-publish after a new commit you have to remove the
build
label and add it again. This will generate a new version using the short commit SHA as suffixYou can check the last version published for this PR here
publish
fails if version already exists). Using the--git-tag-version
doesn't work if the package is inside a subdir. (npm bug here)New Dependency Submission
New
oclif
packages is added into the NPM dev dependencies. This is required because we thenpx oclif manifest
fails using--tag ...
becausenpx
uses the specified tag to try install theoclif
packages. When it is present as a package it works.