Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cache and bundler after build to save size #1859

Closed
wants to merge 37 commits into from

Conversation

sanghinitin
Copy link

Remove cache and bundler after build to save size

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

sanghinitin and others added 30 commits September 17, 2024 10:32
Signed-off-by: nitin sanghi <nsanghi@progress.com>
Signed-off-by: nitin sanghi <nsanghi@progress.com>
Signed-off-by: nitin sanghi <nsanghi@progress.com>
Signed-off-by: nitin sanghi <nsanghi@progress.com>
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
Signed-off-by: nitin sanghi <nsanghi@progress.com>
Signed-off-by: nitin sanghi <nsanghi@progress.com>
Signed-off-by: nitin sanghi <nsanghi@progress.com>
Signed-off-by: nitin sanghi <nsanghi@progress.com>
Signed-off-by: nitin sanghi <nsanghi@progress.com>
Signed-off-by: nitin sanghi <nsanghi@progress.com>
Signed-off-by: nitin sanghi <nsanghi@progress.com>
Signed-off-by: nitin sanghi <nsanghi@progress.com>
Signed-off-by: nitin sanghi <nsanghi@progress.com>
Signed-off-by: nitin sanghi <nsanghi@progress.com>
Adding dev channel publish hab channel
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
Merge Backup/workstation lts to workstation-LTS
Signed-off-by: muthuja <muthujabavaji.vempalli@progress.com>
test verify pipeline creation by expeditor
Signed-off-by: muthuja <muthujabavaji.vempalli@progress.com>
Signed-off-by: muthuja <muthujabavaji.vempalli@progress.com>
Signed-off-by: muthuja <muthujabavaji.vempalli@progress.com>
muthuja and others added 7 commits December 19, 2024 15:46
Signed-off-by: muthuja <muthujabavaji.vempalli@progress.com>
Signed-off-by: muthuja <muthujabavaji.vempalli@progress.com>
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
Obvious fix; these changes are the result of automation not creative thinking.
Signed-off-by: nitin sanghi <nsanghi@progress.com>
@sanghinitin sanghinitin requested review from a team as code owners January 10, 2025 07:37
Base automatically changed from workstation-LTS to main January 28, 2025 19:44
@johnmccrae johnmccrae requested review from a team as code owners January 28, 2025 19:44
# This publish is triggered by the `built_in:publish_rubygems` artifact_action.
rubygems:
- ohai
artifact_channels:
- dev

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please confi8rm this is correct. I have seen unstable and chef-dke-lts2024 for other projects.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sanghinitin can you confirm?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, i will rebase then it will be fixed

Copy link
Contributor

@tpowell-progress tpowell-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit history on this one looks questionable. Can we rebase to clean that up being ready for review?

@tpowell-progress tpowell-progress added the Status: Waiting on Contributor A pull request that has unresolved requested actions from the author. label Feb 11, 2025
# This publish is triggered by the `built_in:publish_rubygems` artifact_action.
rubygems:
- ohai
artifact_channels:
- dev

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sanghinitin can you confirm?

@sanghinitin sanghinitin changed the base branch from main to backup/workstation-LTS February 12, 2025 01:49
@sanghinitin sanghinitin changed the base branch from backup/workstation-LTS to main February 12, 2025 01:49
@sanghinitin
Copy link
Author

Creating Another PR that would be easy instead of Rebase. only 2 line are changed

@sanghinitin sanghinitin deleted the fix_hab_pkg_size branch February 12, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Waiting on Contributor A pull request that has unresolved requested actions from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants